On 12/03/2023 10:32, Joel Selvaraj wrote: > Add devicetree bindings for the Focaltech FTS touchscreen drivers. > > Signed-off-by: Joel Selvaraj <joelselvaraj.oss@xxxxxxxxx> > Signed-off-by: Caleb Connolly <caleb@xxxxxxxxxxxxx> > --- > .../input/touchscreen/focaltech,fts.yaml | 81 +++++++++++++++++++ > 1 file changed, 81 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/focaltech,fts.yaml > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/focaltech,fts.yaml b/Documentation/devicetree/bindings/input/touchscreen/focaltech,fts.yaml > new file mode 100644 > index 000000000000..07fe595cc9ed > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/focaltech,fts.yaml I have doubts you will cover here all possible FTS controllers, so filename should be more specific, e.g. choose the oldest device compatible. > @@ -0,0 +1,81 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/focaltech,fts.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Focaltech FTS I2C Touchscreen Controller > + > +maintainers: > + - Joel Selvaraj <joelselvaraj.oss@xxxxxxxxx> > + - Caleb Connolly <caleb@xxxxxxxxxxxxx> > + > +allOf: > + - $ref: touchscreen.yaml# > + > +properties: > + compatible: > + enum: > + - focaltech,fts5452 > + - focaltech,fts8719 Missing blank line > + reg: > + const: 0x38 > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: > + maxItems: 1 > + > + avdd-supply: > + description: a phandle for the regulator supplying analog power (2.6V to 3.3V). Drop "a phandle for the" > + > + vddio-supply: > + description: a phandle for the regulator supplying IO power (1.8V). Ditto > + > + focaltech,max-touch-number: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: max number of fingers supported Why this is not implied from compatible? IOW, why this differs between boards? If this property stays, then anyway "focaltech,max-touch", not number. There is no such unit suffix as number. > + minimum: 2 > + maximum: 10 > + > + touchscreen-size-x: true > + touchscreen-size-y: true Drop these two > + > +additionalProperties: false and then use unevaluatedProperties: false so all properties from common schema apply. Unless these are not really valid for the *device*? > + > +required: > + - compatible > + - reg > + - reset-gpios > + - focaltech,max-touch-number > + - touchscreen-size-x > + - touchscreen-size-y > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/gpio/gpio.h> > + &i2c5 { i2c > + status="okay"; Drop status Anyway this should pop warnings... Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). > + > + touchscreen: focaltech@38 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Also, drop label touchscreen. > + compatible = "focaltech,fts8719"; > + reg = <0x38>; > + interrupt-parent = <&tlmm>; > + interrupts = <31 IRQ_TYPE_EDGE_RISING>; > + Best regards, Krzysztof
