On 24/02/2023 19.20, Sasha Finkelstein via B4 Relay wrote: > Hi. > > This series adds support for Apple touchscreens using the Z2 protocol. > Those are used as the primary touchscreen on mobile Apple devices, and for the > touchbar on laptops using the M-series chips. (T1/T2 laptops have a coprocessor > in charge of speaking Z2 to the touchbar). > > Sending this as a RFC for now, since this series requires the SPI controller > support which is not upstream yet: > https://lore.kernel.org/all/20211212034726.26306-1-marcan@xxxxxxxxx/ > > Signed-off-by: Sasha Finkelstein <fnkl.kernel@xxxxxxxxx> Just FWIW, I'm happy to see this get RFCed early (early review is always good), but I don't think we should submit it until it actually gets some testing in real-world scenarios. That is naturally blocked on having a MIPI display driver, since a touchscreen above a dead screen isn't terribly useful. Otherwise, we might realize that we have some binding/API issues we missed that are harder to fix after the fact. So let's hold off on submission proper until we have the screen working and some basic userspace tooling to go with all this shipping downstream and it gets some real-world testing. Hopefully by then I'll have sent out the SPI controller driver too :) - Hector
