Hi Dmitry, On 2/25/23 10:27, Dmitry Torokhov wrote: > Hi Lyude, > > On Sat, Feb 25, 2023 at 02:14:27AM +0100, Lyude Paul wrote: >> Poke, Dmitry - any chance we could get this pushed? > > I was waiting for Vicki to respond to Mattijs' comments... > > Thanks. > I'm a little confused as to what's happened here. This appears to be the thread for the v1 of this patch, but the v2 appeared later in a separate series (https://lore.kernel.org/linux-input/20230203022758.3982393-1-vi@xxxxxxxxxxx/T/#m98b35653c34a180e08cebb63b43b3690943f6e77) that was reviewed already. It moves the check into a separate function that will wind up properly freeing the URB if it fails. I tried moving it directly into probe, but that broke resume; it works properly when put in this function. Vicki
