On 1/18/23 09:49, Jiri Kosina wrote:
On Sun, 18 Dec 2022, Adrian Freund wrote:
This patch adds support for the tablet mode switch sensors on
convertible devices where that sensor is managed by AMD SFH, like the
Asus Flow X13 and the Lenovo ThinkPad L13 Yoga Gen2 (AMD).
Co-developed-by: Ivan Dovgal <iv.dovg@xxxxxxxxx>
Signed-off-by: Ivan Dovgal <iv.dovg@xxxxxxxxx>
Co-developed-by: Luke D. Jones <luke@xxxxxxxxxx>
Signed-off-by: Luke D. Jones <luke@xxxxxxxxxx>
Signed-off-by: Adrian Freund <adrian@xxxxxxxxx>
Basavaraj, could you please review this? Thanks,
I think this doesn't need a review right now. I recently found some big
problems with the patch recently and am working on an updated version. I
think reviewing once I send v3 should be enough.
In short: This patch generates nonsensical HID messages that don't even
contain the sensor state.
It still makes the tablet-mode-switch work on some but not all devices
due to a mechanism I don't fully understand yet. Somehow ACPI devices
that previously did nothing suddenly work with this patch and are then
getting picked up by various platform drivers depending on the device.
This driver however doesn't properly handle the actual data directly
from the sensor.
---
Adrian
