On 11/08/22 06:56, Ike Panhc wrote: > On 10/29/22 20:03, Eray Orçunus wrote: > > Nowadays many laptops have camera access keys, yet there is no usage codes > > mapped to them, even though it's introduced in HUTRR72. Start point of > > this patch series was adding it and making IdeaPads send it to userspace. > > But later I discovered that camera_power attribute of ideapad-laptop > > driver on my IdeaPad 520-15IKB doesn't work, so I can't toggle it with > > that. I managed to find a way to check whether an IdeaPad supports > > camera_power attribute (which sends VPCCMD_W_CAMERA to EC), don't expose > > it to sysfs so userspace will know that it can't toggle camera access via > > camera_power, in my case, after receiving KEY_CAMERA_ACCESS_TOGGLE. > > > > Along the way I discovered that old IdeaPads, like S10-3, may not be able > > to toggle their touchpad as a regression of a commit aimed for newer > > IdeaPads, so I reverted it. > > > > Also I noticed that I can get/set the state of my keyboard light, > > so one of the patches also adds supports for this kind of keyboard lights, > > which I call "partially supported keyboard lights". I expect that commit > > to add keyboard light support for 520-15IKB, 330-17ICH, 5 (15) and more. > > Currently only tested on 520-15IKB. > > Thanks. Also test on my ideapad s410 and it looks good. > > Acked-by: Ike Panhc <ike.pan@xxxxxxxxxxxxx> Thank you :) I need some advice since I'm new in here, sadly another patch has been merged to ideapad-laptop along the way and currently it's not possible to merge patch #7, does that mean I should send v3 of my patch series? And whom should I wait for merge, x86 platform drivers maintainers? I think that is the only subsystem whose maintainers haven't replied yet. -eray
