On 10/29/22 20:03, Eray Orçunus wrote: > Nowadays many laptops have camera access keys, yet there is no usage codes > mapped to them, even though it's introduced in HUTRR72. Start point of > this patch series was adding it and making IdeaPads send it to userspace. > But later I discovered that camera_power attribute of ideapad-laptop > driver on my IdeaPad 520-15IKB doesn't work, so I can't toggle it with > that. I managed to find a way to check whether an IdeaPad supports > camera_power attribute (which sends VPCCMD_W_CAMERA to EC), don't expose > it to sysfs so userspace will know that it can't toggle camera access via > camera_power, in my case, after receiving KEY_CAMERA_ACCESS_TOGGLE. > > Along the way I discovered that old IdeaPads, like S10-3, may not be able > to toggle their touchpad as a regression of a commit aimed for newer > IdeaPads, so I reverted it. > > Also I noticed that I can get/set the state of my keyboard light, > so one of the patches also adds supports for this kind of keyboard lights, > which I call "partially supported keyboard lights". I expect that commit > to add keyboard light support for 520-15IKB, 330-17ICH, 5 (15) and more. > Currently only tested on 520-15IKB. Thanks. Also test on my ideapad s410 and it looks good. Acked-by: Ike Panhc <ike.pan@xxxxxxxxxxxxx>
