On Tue, Oct 25, 2022 at 02:29:27PM +0200, Hans de Goede wrote: > On ACPI systems (irq_pin_access_method == IRQ_PIN_ACCESS_ACPI_*) the driver > does not reset the controller at probe time, because sometimes the system > firmware loads a config and resetting might loose this config. > > On the Nanote UMPC-01 device OTOH the config is in flash of the controller, > the controller needs a reset to load this; and the system firmware does not > reset the controller on a cold boot. > > To fix the Nanote UMPC-01 touchscreen not working on a cold boot, try > resetting the controller and then re-reading the config when encountering > a config with 0 width/height/max_touch_num value and the controller has > not already been reset by goodix_ts_probe(). > > This should be safe to do in general because normally we should never > encounter a config with 0 width/height/max_touch_num. Doing this in > general not only avoids the need for a DMI quirk, but also might help > other systems. > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> Applied, thank you. -- Dmitry
