On 23/09/2022 11:55, Quentin Schulz wrote: >>> + >>> + leds { >>> + compatible = "gpio-leds"; >> >> This belongs to DTSI. >> > > It is in the DTSI :) Ah, right... > >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&module_led_pin>; >>> + status = "okay"; >> >> No need. >> >>> + >>> + module_led: led-0 { >> >> Why DTSI - which in logic comes first - starts with 1 and this is 0?\ >> > > The first diff in this patch is for the DTS, this is now the DTSI. So it > does have led-0 in the DTSI and led-1 in the DTS which I think is what > you're requesting here? Is this a correct assumption? Yep. Best regards, Krzysztof