Re: [PATCH] HID: logitech-hidpp: Enable HID++ for all the Logitech Bluetooth devices
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] HID: logitech-hidpp: Enable HID++ for all the Logitech Bluetooth devices
- From: "Peter F. Patel-Schneider" <pfpschneider@xxxxxxxxx>
- Date: Fri, 26 Aug 2022 11:37:57 -0400
- Cc: Filipe Laíns <lains@xxxxxxxxxx>, Jiri Kosina <jikos@xxxxxxxxxx>, Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>, linux-input@xxxxxxxxxxxxxxx
- In-reply-to: <d3824bda564871c7759fd3b1ebad16b3d9affe1e.camel@hadess.net>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0
Looking at https://bugzilla.kernel.org/show_bug.cgi?id=215699 reminded me of
another problem with the driver code. Several HID++ 2.0 features, including
the HiRes Wheel, have commands with bit fields in them and set all the bits in
the bit field at once. But when the driver code sets the high-resolution bit
for this feature it also sets two other bits, ignoring their current setting.
This prevents other software from reliably using these two other bits, one of
which is for reporting wheel movement in the opposite direction, a. k. a.
natural scrolling.
It would be useful for the driver code to first get the other bits and set
them to their retrieved values.
peter
[Index of Archives]
[Linux Media Devel]
[Linux USB Devel]
[Video for Linux]
[Linux Audio Users]
[Yosemite News]
[Linux Kernel]
[Linux SCSI]
[Linux Wireless Networking]
[Linux Omap]