Adding Peter, as he maintains Solaar, one popular application that supports Logitech bluetooth devices. @Peter F. Patel-Schneider -nestor On Thu, Aug 25, 2022 at 2:29 PM Bastien Nocera <hadess@xxxxxxxxxx> wrote: > > Probe for HID++ support over Bluetooth for all the Logitech Bluetooth > devices. As Logitech doesn't have a list of Bluetooth devices that > support HID++ over Bluetooth, probe every device. The HID++ driver > will fall back to plain HID if the device does not support HID++. > > Note that this change might cause upower to export 2 batteries for > certain Bluetooth LE devices which export their battery information > through the Bluetooth BATT profile. This particular bug is tracked at: > https://gitlab.freedesktop.org/upower/upower/-/issues/166 > > Tested with a Logitech Signature M650 mouse, over Bluetooth > > Signed-off-by: Bastien Nocera <hadess@xxxxxxxxxx> > --- > > Note that I could not test whether the Harmony PS3 (handled in hid-sony.c) > or DiNovo Edge keyboard (handled in hid-input.c) devices would correctly fallback > to those drivers in that case. > > Ways to test this would be appreciated (or merge this, and wait for feedback...) > > drivers/hid/hid-logitech-hidpp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c > index 81de88ab2ecc..86e7a38d8a9a 100644 > --- a/drivers/hid/hid-logitech-hidpp.c > +++ b/drivers/hid/hid-logitech-hidpp.c > @@ -4347,6 +4347,9 @@ static const struct hid_device_id hidpp_devices[] = { > { /* MX Master 3 mouse over Bluetooth */ > HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb023), > .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 }, > + > + { /* And try to enable HID++ for all the Logitech Bluetooth devices */ > + HID_DEVICE(BUS_BLUETOOTH, HID_GROUP_ANY, USB_VENDOR_ID_LOGITECH, HID_ANY_ID) }, > {} > }; > > -- > 2.37.2 >
