On Thu, Aug 18, 2022 at 03:53:01PM +0200, Pavel Rojtberg wrote: > Am 18.08.22 um 15:11 schrieb Greg KH: > > On Thu, Aug 18, 2022 at 03:00:20PM +0200, Pavel Rojtberg wrote: > >> From: Santosh De Massari <s.demassari@xxxxxxxxx> > >> > >> Newer gamepads turn themselves off when the mode button is held down. > >> For XBOX360W gamepads we must do this in the driver. > >> > >> Do not use BIT() macro for consistency within the file. > > > > You can fix the file up to properly use the BIT() macro :) > > > > thanks, > > > > greg k-h > > That change should be a separate patch anyway, no? Yes. > Can we postpone this to the next patch series? Sure, it's just not good to keep postponing it to allow you to keep having to justify not using it in new changes. thanks, greg k-h
