Re: [PATCH 2/4] Input: xpad - fix wireless 360 controller breaking after suspend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 18, 2022 at 03:51:55PM +0200, Pavel Rojtberg wrote:
> Am 18.08.22 um 15:10 schrieb Greg KH:
> > On Thu, Aug 18, 2022 at 03:00:19PM +0200, Pavel Rojtberg wrote:
> >> From: Cameron Gutman <aicommander@xxxxxxxxx>
> >>
> >> Suspending and resuming the system can sometimes cause the out
> >> URB to get hung after a reset_resume. This causes LED setting
> >> and force feedback to break on resume. To avoid this, just drop
> >> the reset_resume callback so the USB core rebinds xpad to the
> >> wireless pads on resume if a reset happened.
> >>
> >> A nice side effect of this change is the LED ring on wireless
> >> controllers is now set correctly on system resume.
> >>
> >> Signed-off-by: Cameron Gutman <aicommander@xxxxxxxxx>
> >> Signed-off-by: Pavel Rojtberg <rojtberg@xxxxxxxxx>
> >> ---
> >>  drivers/input/joystick/xpad.c | 1 -
> >>  1 file changed, 1 deletion(-)
> > 
> > What commit id does this fix?  Should it go to stable kernels?
> > 
> > thanks,
> > 
> > greg k-h
> 
> this is a fixup for 4220f7db1e424f2a086ad41217b5770cc9f003a9.

Great, can you resend and add the Fixes: tag for it like:
	Fixes: 4220f7db1e42 ("Input: xpad - workaround dead irq_out after suspend/ resume")

> It should be applied to stable kernels, too.

Great, it needs a stable tag too.

thanks,

greg k-h



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux