Hi! > > On Sat, Jan 29, 2022 at 05:00:40PM -0600, Samuel Holland wrote: > >> The PinePhone keyboard comes with removable keys, but there is a default > >> layout labeled from the factory. Use this keymap if none is provided in > >> the devicetree. > > > > Why can't we require to have it in device tree? > > We can. I am okay with dropping this patch and making the properties required if > that is preferred. > > The keyboard is supported on at least four device trees (three revisions of > PinePhone, plus the PinePhone Pro), so moving the default keymap to the driver > avoids duplicating that block of data in each device tree/overlay. #include is supported on dts, so there's no need to duplicate the keymaps, etc. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
