Re: [PATCH] Input: adp5588-keys: Remove unused driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 5, 2022 at 8:20 AM Hennerich, Michael
<Michael.Hennerich@xxxxxxxxxx> wrote:
> >
> > The last user is gone since 2018 (commit 4ba66a976072 ("arch: remove
> > blackfin port")). This is an i2c driver, so it could be used on a non-blackfin
> > machine, but this driver requires platform data, so it cannot be bound using
> > device tree.
>
> Hi Uwe,
>
> If we start removing drivers which obviously don't have a mainline in-tree user,
> we would upset up many users of these drivers.
> I agree on updating this driver to make platform data optional.
> We could provide a patch in a few days.
>
> Thoughts?

I think the absence of both a DT binding and platforms that define the
platform_data
is a good indication that there are exactly zero users, I wouldn't
worry about that
unless you know of specific users.

If it turns out that there are users on non-blackfin machines that still run on
modern kernels, you should work with them to make a proper DT binding and
drop the platform_data side of the driver.

        Arnd



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux