On 29/04/2022 08:29, Krzysztof Kozlowski wrote:
> The driver is coming from ancient times, so it is understandable it has
> some old coding style. But it definitely not sailed away. :)
>
>> So by
>> changing this we would break both the existing DT's compliance and also
>> existing Linux kernels.
>> So is lowercase something that is mandated by DT schema, or can we just
>> make an exception here?
>
> This uppercase clock name affects even ARM64 devices, so it seems the
> device is still being used. Therefore I propose to add new clock name,
> old as deprecated and support both in the driver:
>
> kmi->clk = clk_get(&dev->dev, "kmirefclk");
> if (IS_ERR(kmi->clk)) {
> kmi->clk = clk_get(&dev->dev, "KMIREFCLK");
>
> and convert the DTS as well later on.
On the other hand, I don't find this as that important if you do not
have time for it, so I am fine with the exception and uppercase name.
Best regards,
Krzysztof
