On 28/04/2022 19:27, Andre Przywara wrote:
>>> + clock-names:
>>> + items:
>>> + - const: KMIREFCLK
>>
>> lowercase letters only
>
> I am afraid this ship has sailed: the various DTs in the kernel tree use
> it in that way, and the Linux driver insists on that spelling.
The driver is coming from ancient times, so it is understandable it has
some old coding style. But it definitely not sailed away. :)
> So by
> changing this we would break both the existing DT's compliance and also
> existing Linux kernels.
> So is lowercase something that is mandated by DT schema, or can we just
> make an exception here?
This uppercase clock name affects even ARM64 devices, so it seems the
device is still being used. Therefore I propose to add new clock name,
old as deprecated and support both in the driver:
kmi->clk = clk_get(&dev->dev, "kmirefclk");
if (IS_ERR(kmi->clk)) {
kmi->clk = clk_get(&dev->dev, "KMIREFCLK");
and convert the DTS as well later on.
Best regards,
Krzysztof
