Sorry that I'm not familier with policy of Linux. That means I cannot add the code to support Bluetoth accessories in Linux Main line? Samsung's Bluetooth accessories can't be supported forever on a Linux PC? Could you share any material or link for exploit related with this commit? --------- Original Message --------- Sender : gregkh@xxxxxxxxxxxxxxxxxxx <gregkh@xxxxxxxxxxxxxxxxxxx> Date : 2022-03-30 17:32 (GMT+9) Title : Re: (2) (2) Request for reverting the commit for Samsung HID driver On Wed, Mar 30, 2022 at 05:23:08PM +0900, 조준완 wrote: > > > As I said, AP manufacturers don't consider validation of patches. That is not our issue, but yours. > They just import linux patches into their Board Support Packages without consideration. That is good for our changes, but not for yours. > So, I can remove the condition that you made once I add Bluetooh accessories to Samsung driver in Linux Mainline? No, not at all unless you wish to have a broken system? Again, you have the budget and resources to handle the maintenance and support of your out-of-tree changes. That is your responsibility to your customers as per your contracts with them. As written, the in-kernel code is correct and now fixed. If you have modified the driver to do something else, it is your responsibility to ensure that it remains working as there is nothing that we can do about that for obvious reasons. And again, if you remove those lines, you have a known insecure system, which I doubt you want for your devices. Please discuss this with your management as they understand the risks and responsibilities that you have undertaken by having out-of-tree code. That is not our responsibility, but yours. thanks, greg k-h