On Fri, Jan 14, 2022 at 2:37 PM Markus Wageringel <markus.wageringel@xxxxxxxxx> wrote: > > Hi Alex, > > regarding the changes around commit [1] that made it into kernel 5.16, I > hope you do not mind if I message you directly, as I am not sure where > else to bring this up. > > Apparently, the default behavior (when the iso_layout flag is not > configured explicitly) has flipped for my keyboard. > > $ lsusb | grep Keyboard > Bus 001 Device 004: ID 05ac:0246 Apple, Inc. Internal > Keyboard/Trackpad (ISO) > $ cat /sys/bus/hid/devices/0003\:05AC\:0246.000{2,3}/country > 0d > 00 > > As my keyboard is rather old (internal German keyboard of MacBookPro8,1 > 2011), maybe nothing needs to be done about this, so feel free to ignore > this email. After all, one gets the correct behavior by explicitly > setting `iso_layout=1` now, which used to be the default. > > Kind regards, > Markus > > [1] > https://github.com/torvalds/linux/commit/d58cf34a594d34de1a6843f576f82fae40adc0c2 Hi Markus, Thank you for reporting this to me. Unfortunately, I didn't have any foreign MacBooks to test, so I had no way of knowing if any of their keyboards had the quirk. But based on your report, I think it's safe to say that the quirk is present on the "Wellspring 5" and later models. I will send a patch to fix them up. Do you have any other MacBooks that you could test (especially super old ones)? -Alex