On Wed, 5 May 2021, Hans de Goede wrote: > Hi Jiri, Benjamin, > > Here is v2 of what started out as a small series to fix spurious wakeups > on T101HA 2-in-1s. > > This adds the discussed hid_is_usb_device() helper and uses that in: > > "HID: multitouch: Disable event reporting on suspend when our parent is > not a wakeup-source" > > To avoid needing to add a "depends on USB_HID" to hid-multitouch Kconfig > settings. > > I've checked all other hid_is_using_ll_driver(hdev, &usb_hid_driver) callers > and the only one which can truely benefit from the new helper is the > hid-asus driver, which also deals with some I2C devices on some Asus hw. > > All other drivers using hid_is_using_ll_driver(hdev, &usb_hid_driver) > are only for USB devices, so dropping the "depends on USB_HID" does not > make sense for them. > > The one other driver which may benefit from the new hid_is_usb_device() > helper would be the Wacom driver which seems to also support I2C devices, > but that contains a lot of USB specific code, so I don't think we can > easily drop the "depends on USB_HID" there. > > Even though this is a bit if a mixed-bag of patches, their are several > dependencies between them, so these should probably all go on a single > topic branch. Now in for-5.13/upstream-fixes. Thanks, -- Jiri Kosina SUSE Labs
