Hi Jiri, Benjamin,
Here is v2 of what started out as a small series to fix spurious wakeups
on T101HA 2-in-1s.
This adds the discussed hid_is_usb_device() helper and uses that in:
"HID: multitouch: Disable event reporting on suspend when our parent is
not a wakeup-source"
To avoid needing to add a "depends on USB_HID" to hid-multitouch Kconfig
settings.
I've checked all other hid_is_using_ll_driver(hdev, &usb_hid_driver) callers
and the only one which can truely benefit from the new helper is the
hid-asus driver, which also deals with some I2C devices on some Asus hw.
All other drivers using hid_is_using_ll_driver(hdev, &usb_hid_driver)
are only for USB devices, so dropping the "depends on USB_HID" does not
make sense for them.
The one other driver which may benefit from the new hid_is_usb_device()
helper would be the Wacom driver which seems to also support I2C devices,
but that contains a lot of USB specific code, so I don't think we can
easily drop the "depends on USB_HID" there.
Even though this is a bit if a mixed-bag of patches, their are several
dependencies between them, so these should probably all go on a single
topic branch.
Regards,
Hans
Hans de Goede (6):
HID: core: Remove extraneous empty line before
EXPORT_SYMBOL_GPL(hid_check_keys_pressed)
HID: core: Add a hid_is_usb_device() helper function
HID: multitouch: Disable event reporting on suspend on the Asus T101HA
touchpad
HID: multitouch: Disable event reporting on suspend when our parent is
not a wakeup-source
HID: asus: Cleanup Asus T101HA keyboard-dock handling
HID: asus: Switch to the new hid_is_usb_device() helper
drivers/hid/Kconfig | 2 +-
drivers/hid/hid-asus.c | 26 ++++++++-----------
drivers/hid/hid-core.c | 11 +++++++-
drivers/hid/hid-multitouch.c | 49 ++++++++++++++++++++++++++++++++++--
include/linux/hid.h | 1 +
5 files changed, 70 insertions(+), 19 deletions(-)
--
2.31.1
