On Fri, Apr 16, 2021 at 10:47:11AM +0200, Krzysztof Kozlowski wrote: > On Fri, 16 Apr 2021 at 05:18, <zhuguangqing83@xxxxxxxxx> wrote: > > > > From: Guangqing Zhu <zhuguangqing83@xxxxxxxxx> > > > > Coccinelle noticed: > > drivers/input/touchscreen/goodix.c:497:8-33: ERROR: Threaded IRQ with no > > primary handler requested without IRQF_ONESHOT > > > > Signed-off-by: Guangqing Zhu <zhuguangqing83@xxxxxxxxx> > > --- > > drivers/input/touchscreen/goodix.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > Did you test it? There are several patches like this all over the tree > so it looks like "let's fix everything from Coccinelle" because you > ignored at least in some of the cases that the handler is not the > default primary one. I am not saying that the change is bad, but > rather it looks automated and needs more consideration. At least the subject is bad because IRQF_ONESHOT is not missing, it is simply set up elsewhere, the patch itself is a noop. I do not see a reason to take this. Thanks. -- Dmitry
