From: Guangqing Zhu <zhuguangqing83@xxxxxxxxx> Coccinelle noticed: drivers/input/touchscreen/goodix.c:497:8-33: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Signed-off-by: Guangqing Zhu <zhuguangqing83@xxxxxxxxx> --- drivers/input/touchscreen/goodix.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c index c682b028f0a2..725d01e01328 100644 --- a/drivers/input/touchscreen/goodix.c +++ b/drivers/input/touchscreen/goodix.c @@ -496,7 +496,8 @@ static int goodix_request_irq(struct goodix_ts_data *ts) { return devm_request_threaded_irq(&ts->client->dev, ts->client->irq, NULL, goodix_ts_irq_handler, - ts->irq_flags, ts->client->name, ts); + ts->irq_flags | IRQF_ONESHOT, + ts->client->name, ts); } static int goodix_check_cfg_8(struct goodix_ts_data *ts, const u8 *cfg, int len) @@ -1158,7 +1159,7 @@ static int goodix_configure_dev(struct goodix_ts_data *ts) return error; } - ts->irq_flags = goodix_irq_flags[ts->int_trigger_type] | IRQF_ONESHOT; + ts->irq_flags = goodix_irq_flags[ts->int_trigger_type]; error = goodix_request_irq(ts); if (error) { dev_err(&ts->client->dev, "request IRQ failed: %d\n", error); -- 2.17.1