Hi Linus, On Thu, Apr 08, 2021 at 03:11:46PM +0200, Linus Walleij wrote: > + > + interrupts: > + description: Interrupt to host, must be flagged as > + IRQ_TYPE_EDGE_FALLING. I do not think this is such a great idea to mandate falling edge interrupt. In fact, on devices that can support it I think level interrupts would be better. And I would prefer if we dropped IRQF_TRIGGER_FALLING from devm_request_threaded_irq() in drivers/input/touchscreen/cyttsp_core.c and rely on the platform to specify appropriate trigger. Thanks. -- Dmitry
