Hi Linus, On Thu, Apr 08, 2021 at 03:11:53PM +0200, Linus Walleij wrote: > This device is certainly a very simple touchscreen so > we set INPUT_MT_DIRECT. > > The sibling driver for CY8CTMA140 also sets > INPUT_MT_DROP_UNUSED and experimenting with this driver > it clearly does not hurt: the touchscreen is working just > fine so let's set it for this one as well. This is not a good justification, and INPUT_MT_DROP_UNUSED is essentially a noop if the driver does not use input_mt_sync_frame(). I dropped INPUT_MT_DROP_UNUSED from the patch and applied, but I would appreciate a followup patch switching the driver to INPUT_MT_DROP_UNUSED and adding input_mt_sync_frame() to cyttsp_report_tchdata() and removing manual release of inactive slots from there (the "used" bitmap). Thanks. -- Dmitry
