On Wed, Jan 13, 2021 at 5:39 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > Quoting Philip Chen (2021-01-13 17:29:05) > > On Wed, Jan 13, 2021 at 3:14 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > > > > > Quoting Philip Chen (2021-01-13 14:47:18) > > > > On Tue, Jan 12, 2021 at 10:49 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > > > > > > > > > Quoting Philip Chen (2021-01-12 15:55:28) > > > > > > On Mon, Jan 11, 2021 at 6:24 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > > > > > > > > > > > > > Is it documented in Documentation/ABI/? > > > > > > Not yet. > > > > > > Is it proper to add the documentation to `testing/sysfs-driver-input-keyboard`? > > > > > > > > > > Somewhere in testing is fine. I'm not sure if it is a generic proprty > > > > > for all keyboards though? What's the path in sysfs? > > > > I wouldn't say it's generic. > > > > It is available in the keyboard device node only when the board has a > > > > custom top-row keyboard design. > > > > The path in sysfs is something like: > > > > /sys/class/input/input0/device/function_row_physmap, where input0 is > > > > cros_ec. > > > > > > I see that atkbd already has this so at least it would be common to some > > > sort of keyboard device. I'm not sure where to document it though. I see > > > that atkbd has a handful of undocumented sysfs attributes so adding all > > > of those may lead to a common path. At the least it sounds OK to have a > > > sysfs-driver-input-keyboard file if input folks are OK with it. > > Since there are other undocumented sysfs attributes for input/keyboard > > anyway, we should probably leave the documentation to another patch? > > For now, let's move to patch v5, where I've addressed all of the > > comments so far. > > Please document this one that's being introduced. We should document all > the sysfs attributes but we don't always do a good job at it. OK, will do!
