On Tue, May 05, 2020 at 09:03:24PM +0530, Aishwarya Ramakrishnan wrote: > It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file > operation rather than DEFINE_SIMPLE_ATTRIBUTE. No it is not, why do you think so? The two defines do different things, that is why we have 2 different defines. You can not just replace one with the other without understanding why one was used and not the other one. Did you test this change to verify that everything still works properly? Why is it needed to be changed at all? thanks, greg k-h
