Hey Roy,
On Mon, Mar 02, 2020 at 01:52:30AM +0000, Roy Im wrote:
> On Monday, March 2, 2020 6:20 AM, Uwe Kleine-König wrote:
> > On Sat, Feb 29, 2020 at 12:59:20AM +0000, Roy Im wrote:
> > > Okay, thanks. I have tried to update that as below.
> > > Could I get your comment if you still see anything on this?
> > >
> > > /* Maximum gain is 0x7fff for PWM mode */
> > > #define MAX_MAGNITUDE_SHIFT 15
> > > [...]
> > > period_mag_multi >>= MAX_MAGNITUDE_SHIFT;
> > >
> > > /* The interpretation of duty cycle depends on the acc_en,
> > > * it should be from 50% to 100% for acc_en = 0.
> > > * See datasheet 'PWM mode' section for more details.
> > > */
> > > if (!haptics->acc_en) {
> > > period_mag_multi += state.period;
> > > period_mag_multi /= 2;
> > > }
> >
> > Much better. Extra points if you add a link to the datasheet at the top of the driver. I didn't look at the datasheet and
> > assume that the reasoning is obvious then.
>
> Okay, then do you think it would be better to remove that comment(the 3rd line - datasheet)?.
No, please keep the reference.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
