Hi Siarhei, Thanks for catching that. I'll fix it for the next rev. I'll also do a sanity check compilation for each patch in the series. -Daniel On Thu, Jan 9, 2020 at 2:55 PM Siarhei Vishniakou <svv@xxxxxxxxxx> wrote: > > Hi Daniel, > > I just tried to build the first patch in isolation, and I'm hitting a build error: in the function nintendo_hid_remove, the variable "ctrl" is unused. It looks like it's first used in the rumble patch, 'add rumble support'. Could you please move that variable declaration there? > > Also, in the same rumble patch, I'm seeing that the function 'joycon_enable_rumble' is always called with the second parameter bool enable = true. Maybe that parameter can be removed from the function definition?
