pt., 10 sty 2020 o 19:28 Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> napisał(a): > > On Tue, Dec 10, 2019 at 11:07:53AM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > > > > We need the of_match table if we want to use the compatible string in > > the pmic's child node and get the onkey driver loaded automatically. > > Do we really need of_match table or adding > Not really. Technically not anyway but we merged bindings that define it (at the time I didn't know any better) and seems we're stuck with it. Please see the discussion below a similar patch for regulator subsystem[1]. > MODULE_ALIAS("platform:max77650-onkey"); > This is already in there, but if someone defines the compatible in the device tree as per bindings, the module won't be loaded despite the MODULE_ALIAS() definition. > will work as well? > > In general, do we ever instantiate onkey portion from device tree? Or > is it always an MFD cell that is instantiated unconditionally? > Bart [1] https://lkml.org/lkml/2019/12/10/271