I think I'm finally satisfied with the subcommand sending reliability.
I've left a controller plugged in for hours constantly blinking the
player LEDs and sending rumble data without any dropped subcommands.
Unless someone finds an issue or something to improve with this
patchset, I think it's in a stable place.
Version 8 changes:
- Corrected the handshaking protocol with USB pro controllers. A
handshake now occurs both prior and after the baudrate set. This
doesn't appear to have a noticeable difference, but it more
accurately follows documentation found online.
- Fixed potential race condition which could lead to a slightly longer
delay sending subcommands in rare circumstances.
- Moved the rumble worker to its own workqueue, since it can block.
This prevents it from having a negative impact on the default kernel
workqueue. It also prevents dropped subcommands due to something
else blocking the kernel workqueue. The benefit is most obvious when
using multiple controllers at once, since the controller subcommand
timings are very picky.
- Added a patch to set the most significant bit of the hid hw version.
Roderick had mentioned needing to probably do this awhile ago, but I
had forgotten about it until now. This is the same thing hid-sony
does. It allows SDL2 to have different mappings for the hid-nintendo
driver vs the default hid mappings.
Version 7 changes:
- Changed name to hid-nintendo to fit modern naming conventions
- Removed joycon_ctlr_destroy(), since it wasn't needed an could
potentially invalidate a mutex while it could be in use on other
threads
- Implemented minor code improvements suggested by Silvan
- The driver now waits to send subcommands until after receiving an
input report. This significantly reduces dropped subcommands.
- Reduced the number of error messages when disconnecting a
controller.
Version 6 changes:
- Improved subcommand sending reliabilty
- Decreased rumble period to 50ms
- Added rumble queue to avoid missing ff_effects if sent too quickly
- Code cleanup and minor refactoring
- Added default analog stick calibration
Version 5 changes:
- Removed sysfs interface to control motor frequencies.
- Improved rumble reliability by using subcommands to set it.
- Changed mapping of the SL/SR triggers on the joy-cons to map to
whichever triggers they lack (e.g. a left joycon's sl/sr map to
TR and TR2). This allows userspace to distinguish between the
normal and S triggers.
- Minor refactors
Version 4 changes:
- Added support for the Home button LED for the pro controller and
right joy-con
- Changed name from hid-switchcon to hid-joycon
- Added rumble support
- Removed ctlr->type and use hdev->product instead
- Use POWER_SUPPLY_CAPACITY_LEVEL enum instead of manually translating
to capacity percentages
- Misc. minor refactors based on v3 feedback
Version 3 changes:
- Added led_classdev support for the 4 player LEDs
- Added power_supply support for the controller's battery
- Made the controller number mutex static
- Minor refactoring/style fixes based on Roderick's feedback from v2
Version 2 changes:
- Switched to using a synchronous method for configuring the
controller.
- Removed any pairing/orientation logic in the driver. Every
controller now corresponds to its own input device.
- Store controller button data as a single u32.
- Style corrections
Daniel J. Ogorchock (9):
HID: nintendo: add nintendo switch controller driver
HID: nintendo: add player led support
HID: nintendo: add power supply support
HID: nintendo: add home led support
HID: nintendo: add rumble support
HID: nintendo: improve subcommand reliability
HID: nintendo: send subcommands after receiving input report
HID: nintendo: reduce device removal subcommand errors
HID: nintendo: patch hw version for userspace HID mappings
MAINTAINERS | 6 +
drivers/hid/Kconfig | 24 +
drivers/hid/Makefile | 1 +
drivers/hid/hid-ids.h | 3 +
drivers/hid/hid-nintendo.c | 1518 ++++++++++++++++++++++++++++++++++++
5 files changed, 1552 insertions(+)
create mode 100644 drivers/hid/hid-nintendo.c
--
2.23.0
