Hi Yizhuo, On Thu, Oct 03, 2019 at 01:29:05PM -0700, Yizhuo Zhai wrote: > Hi Dmitry: > > Variable "intr_status" and "raw_coordinate" in function > iproc_touchscreen_interrupt()( > (drivers/input/touchscreen/bcm_iproc_tsc.c) could be uninitialized if > regmap_read() returns -EINVAL. But it's directly used later without > the return check, which is potentially unsafe. > > Also, we cannot simply return -EINVAL in iproc_touchscreen_interrupt() > because it is out of the return type: irqreturn_t. The same cases > happen in function mx25_tcq_irq() with variable "stat" and function > mx25_tcq_init() with variable "tgcr". > > Thanks for your time to check this case. Both of these drivers use MMIO to interact with the hardware, so regmap failing is purely theoretical possibility. Thanks. -- Dmitry
