Potential uninitialized variables in subsys input: bcm_iproc_tsc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dmitry:

Variable "intr_status" and "raw_coordinate" in function
iproc_touchscreen_interrupt()(
(drivers/input/touchscreen/bcm_iproc_tsc.c) could be uninitialized if
regmap_read() returns -EINVAL. But it's directly used later without
the return check, which is potentially unsafe.

Also, we cannot simply return -EINVAL in iproc_touchscreen_interrupt()
because it is out of the return type: irqreturn_t. The same cases
happen in function  mx25_tcq_irq() with variable "stat" and function
mx25_tcq_init() with variable "tgcr".

Thanks for your time to check this case.
-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux