On 19-09-17 19:32, Andy Shevchenko wrote: > On Tue, Sep 17, 2019 at 05:58:05PM +0200, Marco Felsch wrote: > > Since day one the touch controller acts as wakeup-source. This seems to > > be wrong since the device supports deep-sleep mechanism [1] which > > requires a reset to leave it. Also some designs won't use the > > touchscreen as wakeup-source. > > > > Add a firmware property to address this. The common 'wakeup-source' > > property can't be used for that because the driver must be backward > > compatible with old firmwares which may assume the default on > > wakeup-source behaviour. So we need to go the other way by explicit > > disable the wakeup-source capability. > > > > > [1] https://www.newhavendisplay.com/appnotes/datasheets/touchpanel/ \ > > FT5x26.pdf > > Please, don't split URLs Hm.. then checkpatch complains.. If you prefer it, I can change it in the v2. > > int error; > > char fw_version[EDT_NAME_LEN]; > > > + bool en_wakeup; > > Perhaps wakeup_en? I have no strong opinion about that.. Regards, Marco > > -- > With Best Regards, > Andy Shevchenko > > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
