On 19-09-17 19:29, Andy Shevchenko wrote: > On Tue, Sep 17, 2019 at 05:58:03PM +0200, Marco Felsch wrote: > > It seems that the include order is historical increased and no one takes > > care of it. Fix this to align it with the common rule to be in a > > alphabetical order. > > But asm parts we usually put after linux parts. Thanks, I will change it in the v2. Regards, Marco > > > > > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> > > --- > > drivers/input/touchscreen/edt-ft5x06.c | 22 +++++++++++----------- > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c > > index 3cc4341bbdff..9e328a82b765 100644 > > --- a/drivers/input/touchscreen/edt-ft5x06.c > > +++ b/drivers/input/touchscreen/edt-ft5x06.c > > @@ -13,21 +13,21 @@ > > * http://www.glyn.com/Products/Displays > > */ > > > > -#include <linux/module.h> > > -#include <linux/ratelimit.h> > > -#include <linux/irq.h> > > -#include <linux/interrupt.h> > > -#include <linux/input.h> > > -#include <linux/i2c.h> > > -#include <linux/kernel.h> > > -#include <linux/uaccess.h> > > -#include <linux/delay.h> > > +#include <asm/unaligned.h> > > #include <linux/debugfs.h> > > -#include <linux/slab.h> > > +#include <linux/delay.h> > > #include <linux/gpio/consumer.h> > > +#include <linux/i2c.h> > > +#include <linux/interrupt.h> > > +#include <linux/input.h> > > #include <linux/input/mt.h> > > #include <linux/input/touchscreen.h> > > -#include <asm/unaligned.h> > > +#include <linux/irq.h> > > +#include <linux/kernel.h> > > +#include <linux/module.h> > > +#include <linux/ratelimit.h> > > +#include <linux/slab.h> > > +#include <linux/uaccess.h> > > > > #define WORK_REGISTER_THRESHOLD 0x00 > > #define WORK_REGISTER_REPORT_RATE 0x08 > > -- > > 2.20.1 > > > > -- > With Best Regards, > Andy Shevchenko > > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |