On 31.08.2019 18:25, Pali Rohár wrote: > On Thursday 29 August 2019 10:50:39 Dmitry Torokhov wrote: >> On Thu, Aug 29, 2019 at 07:50:23PM +0300, Denis Efremov wrote: >>> "unlikely(IS_ERR_OR_NULL(x))" is excessive. IS_ERR_OR_NULL() already uses >>> unlikely() internally. >> >> The keyword here is _internally_. >> >> https://lore.kernel.org/lkml/20190821174857.GD76194@dtor-ws/ >> >> So please no. > > Dmitry and I already rejected this patch, see also linked-list: > https://lore.kernel.org/lkml/20190820111719.7blyk5jstgwde2ae@pali/ > Looks like this is a very long recurring story with this patch. Thanks, for the clarification. Regards, Denis