On Thursday 29 August 2019 10:50:39 Dmitry Torokhov wrote: > On Thu, Aug 29, 2019 at 07:50:23PM +0300, Denis Efremov wrote: > > "unlikely(IS_ERR_OR_NULL(x))" is excessive. IS_ERR_OR_NULL() already uses > > unlikely() internally. > > The keyword here is _internally_. > > https://lore.kernel.org/lkml/20190821174857.GD76194@dtor-ws/ > > So please no. Dmitry and I already rejected this patch, see also linked-list: https://lore.kernel.org/lkml/20190820111719.7blyk5jstgwde2ae@pali/ > > > > Signed-off-by: Denis Efremov <efremov@xxxxxxxxx> > > Cc: "Pali Rohár" <pali.rohar@xxxxxxxxx> > > Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > Cc: Joe Perches <joe@xxxxxxxxxxx> > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > Cc: linux-input@xxxxxxxxxxxxxxx > > --- > > drivers/input/mouse/alps.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c > > index 34700eda0429..ed1661434899 100644 > > --- a/drivers/input/mouse/alps.c > > +++ b/drivers/input/mouse/alps.c > > @@ -1476,7 +1476,7 @@ static void alps_report_bare_ps2_packet(struct psmouse *psmouse, > > /* On V2 devices the DualPoint Stick reports bare packets */ > > dev = priv->dev2; > > dev2 = psmouse->dev; > > - } else if (unlikely(IS_ERR_OR_NULL(priv->dev3))) { > > + } else if (IS_ERR_OR_NULL(priv->dev3)) { > > /* Register dev3 mouse if we received PS/2 packet first time */ > > if (!IS_ERR(priv->dev3)) > > psmouse_queue_work(psmouse, &priv->dev3_register_work, > > -- > > 2.21.0 > > > -- Pali Rohár pali.rohar@xxxxxxxxx
Attachment:
signature.asc
Description: PGP signature
