Re: [PATCH] platform/x86: touchscreen_dmi: Add info for 'Chuwi Hi10 Pro' touchscreen

[Hans de Goede <hdegoede@xxxxxxxxxx>]

Hi,

On 28-06-19 00:50, Daniel Otero wrote:
> Thanks Hans!
>
> Anything else that I can do to get this accepted?

Nothing more is needed, the platform-x86 driver maintainers should
pick this up soonish.

Regards,

Hans



> Regards,
>
> On Thu, Jun 06, 2019 at 09:33:17AM +0200, Hans de Goede wrote:
> > Hi,
> >
> > On 06-06-19 01:22, Daniel Otero wrote:
> > > Add touchscreen platform data for the 'Chuwi Hi10 Pro' tablet touchscreen.
> > >
> > > Signed-off-by: Daniel Otero <otero.o.daniel@xxxxxxxxx>
> >
> > Patch looks good to me:
> >
> > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> >
> > Regards,
> >
> > Hans
> >
> >
> > > ---
> > >    drivers/platform/x86/touchscreen_dmi.c | 25 +++++++++++++++++++++++++
> > >    1 file changed, 25 insertions(+)
> > >
> > > diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> > > index b662cb2d7cd5..d942082c5b7b 100644
> > > --- a/drivers/platform/x86/touchscreen_dmi.c
> > > +++ b/drivers/platform/x86/touchscreen_dmi.c
> > > @@ -87,6 +87,23 @@ static const struct ts_dmi_data chuwi_hi10_air_data = {
> > >    	.properties	= chuwi_hi10_air_props,
> > >    };
> > > +static const struct property_entry chuwi_hi10_pro_props[] = {
> > > +	PROPERTY_ENTRY_U32("touchscreen-size-x", 1911),
> > > +	PROPERTY_ENTRY_U32("touchscreen-size-y", 1276),
> > > +	PROPERTY_ENTRY_U32("touchscreen-min-x", 9),
> > > +	PROPERTY_ENTRY_U32("touchscreen-min-y", 9),
> > > +	PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
> > > +	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-chuwi-hi10-pro.fw"),
> > > +	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> > > +	PROPERTY_ENTRY_BOOL("silead,home-button"),
> > > +	{ }
> > > +};
> > > +
> > > +static const struct ts_dmi_data chuwi_hi10_pro_data = {
> > > +	.acpi_name	= "MSSL1680:00",
> > > +	.properties	= chuwi_hi10_pro_props,
> > > +};
> > > +
> > >    static const struct property_entry chuwi_vi8_props[] = {
> > >    	PROPERTY_ENTRY_U32("touchscreen-min-x", 4),
> > >    	PROPERTY_ENTRY_U32("touchscreen-min-y", 6),
> > > @@ -601,6 +618,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
> > >    			DMI_MATCH(DMI_PRODUCT_SKU, "P1W6_C109D_B"),
> > >    		},
> > >    	},
> > > +	{
> > > +		/* Chuwi Hi10 Pro (CWI529) */
> > > +		.driver_data = (void *)&chuwi_hi10_pro_data,
> > > +		.matches = {
> > > +			DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
> > > +			DMI_MATCH(DMI_PRODUCT_NAME, "Hi10 pro tablet"),
> > > +		},
> > > +	},
> > >    	{
> > >    		/* Chuwi Vi8 (CWI506) */
> > >    		.driver_data = (void *)&chuwi_vi8_data,