Re: [PATCH] input/touchscreen/sur40: use COLORSPACE_RAW

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27.06.19 10:20, Hans Verkuil wrote:
> On 6/27/19 10:12 AM, Florian Echtler wrote:
>> On 26.06.19 11:52, Hans Verkuil wrote:
>>> This driver set the colorspace to SRGB, but that makes no sense for
>>> a touchscreen. Use RAW instead. This also ensures consistency with the
>>> v4l_pix_format_touch() call that's used in v4l2-ioctl.c.
>>
>> One question for clarification: this will only affect userspace applications
>> which explicitly request a certain colorspace, correct?
> 
> You can't request a colorspace from userspace. The driver sets it.

What I meant is: ... will only affect applications which explicitly search for
formats with a specific colorspace value.

> In this case is it inconsistent anyway since VIDIOC_S_FMT will return RAW
> (due to the v4l_pix_format_touch() call), but G/TRY_FMT will return SRGB
> from the driver. TRY_FMT should return RAW as well, but it didn't call
> v4l_pix_format_touch(), for which I posted a separate patch fixing that.

OK, understood.

Acked-by: Florian Echtler <floe@xxxxxxxxxxxxxx>

Best regards, Florian
-- 
SENT FROM MY DEC VT50 TERMINAL

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux