On Tue, 25 Jun 2019, Bastien Nocera wrote: > > > With initial reviews from Benjamin Tissoires. > > > > I guess this is not the final version of the patch then, and proper > > changelog will be inserted here :) > > I'm not sure what else is needed there. The rest of the information is > in the code, in the Kconfig, etc. "With initial reviews from Benjamin Tissoires" is not really changelog we'd like to end up with in the kernel git. Please consider something like "Add driver for XYZ device" at minimum. > > > Signed-off-by: Bastien Nocera <hadess@xxxxxxxxxx> > > > > [ ... snip ... ] > > > > > +config HID_CREATIVE_SB0540 > > > + tristate "Creative SB0540 infrared receiver" > > > + depends on (USB_HID) > > > > Could you please remove the superfluous parenthesis? > > I copied it from the only other entry that has that parenthesis in the > file: > config HID_APPLEIR > tristate "Apple infrared receiver" > depends on (USB_HID) > > Do you want a patch for that? As you'll be resubmitting with proper changelog, please change this as well. Thanks. > > > --- /dev/null > > > +++ b/drivers/hid/hid-creative-sb0540.c > > > @@ -0,0 +1,254 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * HID driver for the Creative SB0540 receiver > > > + * > > > + * Copyright (C) 2019 Red Hat Inc. All Rights Reserved > > > > Given the fact you're claiming RH copyright, the patch should better > > be > > signed off by from a redhat.com address I believe. > > If that's really needed, then I might as well put my own copyright > there. It's up to you (and your agreement with your employee), it just felt odd. Thanks, -- Jiri Kosina SUSE Labs
