On Tue, 25 Jun 2019, Bastien Nocera wrote: > With initial reviews from Benjamin Tissoires. I guess this is not the final version of the patch then, and proper changelog will be inserted here :) > Signed-off-by: Bastien Nocera <hadess@xxxxxxxxxx> [ ... snip ... ] > +config HID_CREATIVE_SB0540 > + tristate "Creative SB0540 infrared receiver" > + depends on (USB_HID) Could you please remove the superfluous parenthesis? > + ---help--- > + Support for Creative infrared SB0540-compatible remote controls, such > + as the RM-1500 and RM-1800 remotes. > + > + Say Y here if you want support for Creative SB0540 infrared receiver. > + > config HID_CYPRESS > tristate "Cypress mouse and barcode readers" > depends on HID > diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile > index cc5d827c9164..1ad662fe37b6 100644 > --- a/drivers/hid/Makefile > +++ b/drivers/hid/Makefile > @@ -27,6 +27,7 @@ obj-$(CONFIG_HID_ALPS) += hid-alps.o > obj-$(CONFIG_HID_ACRUX) += hid-axff.o > obj-$(CONFIG_HID_APPLE) += hid-apple.o > obj-$(CONFIG_HID_APPLEIR) += hid-appleir.o > +obj-$(CONFIG_HID_CREATIVE_SB0540) += hid-creative-sb0540.c > obj-$(CONFIG_HID_ASUS) += hid-asus.o > obj-$(CONFIG_HID_AUREAL) += hid-aureal.o > obj-$(CONFIG_HID_BELKIN) += hid-belkin.o > diff --git a/drivers/hid/hid-creative-sb0540.c b/drivers/hid/hid-creative-sb0540.c > new file mode 100644 > index 000000000000..a94542cbdd33 > --- /dev/null > +++ b/drivers/hid/hid-creative-sb0540.c > @@ -0,0 +1,254 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * HID driver for the Creative SB0540 receiver > + * > + * Copyright (C) 2019 Red Hat Inc. All Rights Reserved Given the fact you're claiming RH copyright, the patch should better be signed off by from a redhat.com address I believe. Thanks, -- Jiri Kosina SUSE Labs
