Re: [PATCH] HID: wacom: Add support for Pro Pen slim

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jason,

On Tue, Feb 19, 2019 at 7:00 PM Gerecke, Jason <Jason.Gerecke@xxxxxxxxx> wrote:
>
> From: Jason Gerecke <killertofu@xxxxxxxxx>

You almost got it right :)
The email is sent with the proper From, but your patch has an extra
from which breaks checkpatch :/

I think it should be better to send the patch from your gmail address
and add the From: line to your wacom one.

Patch looks good besides that (but you forgot to CC Jiri and myself).

I'll try to apply it later today.

Cheers,
Benjamin

>
> Wacom has introduced a new pen compatible with its MobileStudio Pro and
> other tablets. Although adding it to the tool ID tablet is not strictly
> necessary  unrecognized pens are reported as BTN_TOOL_PEN already, unless
> the tablet sends the "eraser" bit, when BTN_TOOL_RUBBER is used instead),
> we'll keep it updated anyway.
>
> Signed-off-by: Jason Gerecke <jason.gerecke@xxxxxxxxx>
> ---
>  drivers/hid/wacom_wac.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
> index 5ecda99bf431..747730d32ab6 100644
> --- a/drivers/hid/wacom_wac.c
> +++ b/drivers/hid/wacom_wac.c
> @@ -626,6 +626,7 @@ static int wacom_intuos_get_tool_type(int tool_id)
>         case 0x8e2: /* IntuosHT2 pen */
>         case 0x022:
>         case 0x10804: /* Intuos4/5 13HD/24HD Art Pen */
> +       case 0x10842: /* MobileStudio Pro Pro Pen slim */
>         case 0x14802: /* Intuos4/5 13HD/24HD Classic Pen */
>         case 0x16802: /* Cintiq 13HD Pro Pen */
>         case 0x18802: /* DTH2242 Pen */
> @@ -667,6 +668,7 @@ static int wacom_intuos_get_tool_type(int tool_id)
>         case 0x1480a: /* Intuos4/5 13HD/24HD Classic Pen Eraser */
>         case 0x1090a: /* Intuos4/5 13HD/24HD Airbrush Eraser */
>         case 0x1080c: /* Intuos4/5 13HD/24HD Art Pen Eraser */
> +       case 0x1084a: /* MobileStudio Pro Pro Pen slim Eraser */
>         case 0x1680a: /* Cintiq 13HD Pro Pen Eraser */
>         case 0x1880a: /* DTH2242 Eraser */
>         case 0x1080a: /* Intuos4/5 13HD/24HD General Pen Eraser */
> --
> 2.20.1
>



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux