Am Dienstag, den 19.02.2019, 14:16 +0100 schrieb Jiri Kosina: > On Mon, 11 Feb 2019, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wimplicit-fallthrough, mark switch > > cases where we are expecting to fall through. > > > > This patch fixes the following warning: > > > > drivers/hid/hid-roccat-kone.c: In function > > ‘kone_keep_values_up_to_date’: > > drivers/hid/hid-roccat-kone.c:784:20: warning: this statement may > > fall through [-Wimplicit-fallthrough=] > > kone->actual_dpi = kone->profiles[event->value - 1]. > > ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > startup_dpi; > > ~~~~~~~~~~~ > > drivers/hid/hid-roccat-kone.c:786:2: note: here > > case kone_mouse_event_osd_profile: > > ^~~~ > > > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > > > This patch is part of the ongoing efforts to enable > > -Wimplicit-fallthrough. > > > > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> > > --- > > drivers/hid/hid-roccat-kone.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/hid/hid-roccat-kone.c b/drivers/hid/hid- > > roccat-kone.c > > index bf4675a27396..c4dd6162c1d6 100644 > > --- a/drivers/hid/hid-roccat-kone.c > > +++ b/drivers/hid/hid-roccat-kone.c > > @@ -783,6 +783,7 @@ static void kone_keep_values_up_to_date(struct > > kone_device *kone, > > case kone_mouse_event_switch_profile: > > kone->actual_dpi = kone->profiles[event->value - > > 1]. > > startup_dpi; > > + /* fall through */ > > case kone_mouse_event_osd_profile: > > kone->actual_profile = event->value; > > break; > > Stefan, could you please confirm that this is intended behavior? > > Thanks, I already confirmed this 7 months ago but as I see only in a reply to you. Yes, this patch is correct. Stefan
