Re: [PATCH] Input: ps2-gpio - flush TX work when closing port

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] Input: ps2-gpio - flush TX work when closing port
From: Sven Van Asbroeck <thesven73@xxxxxxxxx>
Date: Fri, 8 Feb 2019 11:21:39 -0500
Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>, linux-input@xxxxxxxxxxxxxxx, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <fad6ebf83d088d676f0ba825ad4572ed@dk-develop.de>

On Fri, Feb 8, 2019 at 10:51 AM Danilo Krummrich
<danilokrummrich@xxxxxxxxxxxxx> wrote:
>
> I agree with Dmitry
>

So do I, you guys are absolutely right.
As far as I can see, this patch fixes the user-after-free.
So, after Dmitry changes flush_work() to flush_delayed_work() :

Reviewed-by: Sven Van Asbroeck <TheSven73@xxxxxxxxx>

References:
- [PATCH] Input: ps2-gpio - flush TX work when closing port
  - From: Dmitry Torokhov
- Re: [PATCH] Input: ps2-gpio - flush TX work when closing port
  - From: Sven Van Asbroeck
- Re: [PATCH] Input: ps2-gpio - flush TX work when closing port
  - From: Dmitry Torokhov
- Re: [PATCH] Input: ps2-gpio - flush TX work when closing port
  - From: Danilo Krummrich

Prev by Date: [PATCH v2] Input: st1232 - switch to gpiod API
Next by Date: [RFC PATCH 1/2] Input: lm8323: switch to using set_brightness_blocking
Previous by thread: Re: [PATCH] Input: ps2-gpio - flush TX work when closing port
Next by thread: [PATCH] Input: matrix_keypad - use flush_delayed_work()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Media Devel] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Linux Wireless Networking] [Linux Omap]

Powered by Linux