On Mon, Dec 24, 2018 at 09:02:50AM +0300, Alexander Shiyan wrote:
> >Воскресенье, 23 декабря 2018, 23:10 +03:00 от Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>:
> >
> >On Sun, Dec 23, 2018 at 10:28:50PM +0300, Alexander Shiyan wrote:
> >> >Воскресенье, 23 декабря 2018, 21:15 +03:00 от Dmitry Torokhov < dmitry.torokhov@xxxxxxxxx >:
> >> >
> >> >On Sat, Dec 22, 2018 at 06:54:34PM +0300, Alexander Shiyan wrote:
> >> >> As mentioned in the patch bdb0066df96e ("mfd: syscon: Decouple syscon
> >> >> interface from platform devices"), we need to switch to using the
> >> >> syscon_regmap_lookup_by_phandle() function. This patch makes this change.
> >> >>
> >> >> Signed-off-by: Alexander Shiyan < shc_work@xxxxxxx >
> >> >> ---
> >> >> drivers/input/keyboard/clps711x-keypad.c | 3 +--
> >> >> 1 file changed, 1 insertion(+), 2 deletions(-)
> >> >>
> >> >> diff --git a/drivers/input/keyboard/clps711x-keypad.c b/drivers/input/keyboard/clps711x-keypad.c
> >> >> index e319f74..f7f49da 100644
> >> >> --- a/drivers/input/keyboard/clps711x-keypad.c
> >> >> +++ b/drivers/input/keyboard/clps711x-keypad.c
> >> >> @@ -100,8 +100,7 @@ static int clps711x_keypad_probe(struct platform_device *pdev)
> >> >> if (!priv)
> >> >> return -ENOMEM;
> >> >>
> >> >> -priv->syscon =
> >> >> -syscon_regmap_lookup_by_compatible("cirrus,ep7209-syscon1");
> >> >> +priv->syscon = syscon_regmap_lookup_by_phandle(np, "syscon");
> >> >
> >> >Do we care about compatibility with old DTSes that do not have syscon
> >> >phandle in the keypad descriptor?
> >>
> >> Hello.
> >>
> >> There are no users for this driver in current kernel.
> >> The patch for adding bindings (with syscon phandle) is submitted by me recently.
> >
> >Alexander,
> >
> >The argument that there are no users in kernel works well for adjusting
> >or removing platform data, but does not work for DTS, as it is supposed
> >to be separate from the kernel. The original binding is from 2014 and
> >there might be users of the driver that will not be aware of the change.
> >If anything, if there were users of the driver in DTSes shipped with the
> >kernel, we could make argument that we adjusted them to the new schema
> >and all should be well, but will all users being external that is not
> >the case.
> >
> >I would love to just apply the patch as is, but I am afraid we need to
> >keep compatibility with older DTSes.
>
> Ok, will it be better if we keep the syscon_regmap_lookup_by_compatible()
> call as a fallback method for getting syscon phandle?
>
Yes, please. Just make sure you do not try to fall back if
syscon_regmap_lookup_by_phandle() returns -EPROBE_DEFER, but for all
other errors we should try old syscon_regmap_lookup_by_compatible().
Thanks.
--
Dmitry
