Re: [PATCH 1/1] input: elan_i2c - add support for ELAN061A touchpad

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 24, 2018 at 10:28:45AM +0100, Ingo Lafrenz wrote:
> Add ELAN061A to the ACPI table to support Elan touchpad found in Lenovo
> V130-15IGM laptops
> 
> Signed-off-by: Ingo Lafrenz <ich+linux@xxxxxxxxxxx>
> 
> ---
> I have tested this successfully against the 4.19.11 kernel. Please note
> that since kernel v4.18 the driver generates a looot of 'invalid report
> id data (ff)' messages with this touchpad. So even the touchpad seems
> fully functional for me there might be more to it than just adding the ID.
> Please consider this when taking this patch, otherwise the logs will
> be flooded with tons of messages.

Are you saying that with this patch applied to 4.18 you do not see the
"ff" flood? After 4.18 I only see additions of ACPI IDs to the driver,
any chance you could bisect to see what causes invalid report messages?

> 
> diff --git a/drivers/input/mouse/elan_i2c_core.c
> b/drivers/input/mouse/elan_i2c_core.c
> index 2690a4b7ed53..7cacacfb90e3 100644
> --- a/drivers/input/mouse/elan_i2c_core.c
> +++ b/drivers/input/mouse/elan_i2c_core.c
> @@ -1344,6 +1344,7 @@ static const struct acpi_device_id elan_acpi_id[] = {
>      { "ELAN060B", 0 },
>      { "ELAN060C", 0 },
>      { "ELAN0611", 0 },
> +    { "ELAN061A", 0 },
>      { "ELAN1000", 0 },
>      { }
>  };
> 

Thanks.

-- 
Dmitry



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux