+Cc: Hans to pass this to RH / Fedora (Sorry I don't know better person in RH for kernel stuff like this) On Tue, 2018-07-24 at 11:19 -0700, dmitry.torokhov@xxxxxxxxx wrote: > On Tue, Jul 24, 2018 at 11:55:52AM +0300, Andy Shevchenko wrote: > > On Mon, 2018-07-23 at 10:13 -0700, dmitry.torokhov@xxxxxxxxx wrote: > > > On Mon, Jul 23, 2018 at 04:20:50PM +0300, Andy Shevchenko wrote: > > > > On Mon, 2018-07-23 at 16:18 +0300, Andy Shevchenko wrote: > > > > > On Mon, 2018-07-23 at 15:03 +0200, Lukas Wunner wrote: > > > > > > That function already bails out if x86_platform.legacy.i8042 > > > > > > == > > > > > > X86_LEGACY_I8042_PLATFORM_ABSENT. The check could either be > > > > > > amended with "|| x86_apple_machine" > > > > > > > > In any case this suggestion seems to be the best to cover any > > > > Mac:s. > > > > If > > > > ACPI already has it disabled — we are fine, otherwise bail out > > > > based > > > > on > > > > DMI check. > > > > > > Why would one run with ACPI disabled? > > > I do not think we should be > > > supporting this [mis-]configuration... > > > > The comment was about the bit in FADT table which reflects the i8042 > > presence on platform in the question. You can't for sure check that > > bit > > if ACPI is disabled. By the way, I didn't tell anything about ACPI > > being > > disabled, sorry for confusion. > > Ah, sorry, I misparsed what you said. Anyway, I think we should trust > ACPI there and not add additional DMI quirks unless absolutely > necessary. Just to be clear, DMI quirks for Apple machines are _already_ in the kernel. As Lukas mentioned above it's just matter of adding one more parameter to the condition. But I heard you. It seems Fedora kernel has this patch for years and it also seems it's not needed anymore. In any case I have Cc'ed to Hans who, I suppose, can pass this to the right people in RH to clarify. If RH / Fedora has real use cases where ACPI doesn't have this bit properly set, they perhaps would need to change it to the one discussed here and upstream. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
