Re: [PATCH] Disable i8042 checks on Intel Apple Macs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2018-07-23 at 10:13 -0700, dmitry.torokhov@xxxxxxxxx wrote:
> On Mon, Jul 23, 2018 at 04:20:50PM +0300, Andy Shevchenko wrote:
> > On Mon, 2018-07-23 at 16:18 +0300, Andy Shevchenko wrote:
> > > On Mon, 2018-07-23 at 15:03 +0200, Lukas Wunner wrote:
> > > > That function already bails out if x86_platform.legacy.i8042 ==
> > > > X86_LEGACY_I8042_PLATFORM_ABSENT.  The check could either be
> > > > amended with "|| x86_apple_machine"
> > 
> > In any case this suggestion seems to be the best to cover any Mac:s.
> > If
> > ACPI already has it disabled — we are fine, otherwise bail out based
> > on
> > DMI check.
> 
> Why would one run with ACPI disabled?
>  I do not think we should be
> supporting this [mis-]configuration...

The comment was about the bit in FADT table which reflects the i8042
presence on platform in the question. You can't for sure check that bit 
if ACPI is disabled. By the way, I didn't tell anything about ACPI being
disabled, sorry for confusion.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux