Hi Hanno, We looked over the code and did some extensive testing (in particular making code paths fail, using multiple devices,...). In our testing with DualShock 4 the patches functioned correctly and we didn't spot any issues. Thanks, Roderick On Fri, Jun 15, 2018 at 9:44 PM, Roderick Colenbrander <thunderbird2k@xxxxxxxxx> wrote: > Hi Hanno, > > Thanks for your contributions. My team and I need to have a close look > at some of these changes and QA them again. The situation is that we > (=Sony) are starting to use the driver more and more ourselves and > need to validate bigger changes to ensure quality and prevent > regressions in products. I can't guarantee at the moment when we can > evaluate the changes. Hopefully we can allocate some resources in a > few weeks. > > Thanks, > Roderick > > On Thu, Jun 14, 2018 at 7:28 AM, Hanno Zulla <abos@xxxxxxxx> wrote: >> Hello, >> >> for hid-bigbenff, I used the code of hid-betopff and hid-sony >> to learn about writing a device driver. >> >> Benjamin's review of hid-bigbenff noted that one should use the >> devm_ api calls these days, which served as a motivation to >> refactor this api change into the older code where appropriate. >> >> This removes some device teardown code and makes error handling >> easier. >> >> I tested this with a Sony Dualshock 3 bluetooth gamepad only, >> so additional test reports from other users of the driver may be >> warranted. >> >> Kind regards, >> >> Hanno >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-input" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html