On Fri, Sep 15, 2017 at 9:52 AM, Niels Skou Olsen <nolsen@xxxxxxxxx> wrote: > On Wed, 13 Sep 2017, jikos@xxxxxxxxxx wrote: > >> On Wed, 13 Sep 2017, benjamin.tissoires@xxxxxxxxxx wrote: >> >> > I do not see a reason not to. Maybe Jiri will, but the fact that one >> > version works and one doesn't seem enough to allow such specific >> > blacklisting. >> >> The blacklist matching currently doesn't support that, but it'd be trivial to match, and I >> actually think it generally makes sense to me. So feel free (once you guys settle on >> solution that both Chromium and Jabr folk find acceptable) to send this together with >> a hid-core patch that'd add a possibility to perform per-fw-version matching. > > Great! Shall I give it a shot? Or is there someone with more intimate knowledge > about hid-core that wants to do it? > > How should it work? > > A simple setup would be to attach an optional list of blacklisted firmware versions > to each entry in hid_ignore_list[]? If this list is empty, all firmware versions are > blacklisted. The attached list could just be a static array. Would this be acceptable? Where the firmware version is stored (eg here in bcdUSB) is neither really defined nor available at the pure HID level (ie you likely need the USB descriptors). So probably you want to remove the Jabra devices from the hid_ignore_list[] and add the new versioned quirk returning HID_QUIRK_IGNORE in usbhid_lookup_quirk() [in drivers/hid/usbhid/hid-quirks.c]. It seems we can either create a new list with USB VID/PID/min bcdUSB or actually just add some code for it as this might not extend to tons of devices, but the maintainers can give guidance on this point. -- Vincent -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
