Re-sending (seems I forgot the HTML subpart that linux-input doesn't like) On Fri, Sep 8, 2017 at 3:13 PM, Jiri Kosina <jikos@xxxxxxxxxx> wrote: > > On Tue, 5 Sep 2017, nolsen@xxxxxxxxx wrote: > > > > From: Niels Skou Olsen <nolsen@xxxxxxxxx> > > > > > > Two Jabra speakerphone devices were added to the ignore list in 2013 > > > because, at the time, the device HID interfaces didn't work well with > > > kernel usbhid driver, and could reportedly cause volume key event > > > storm. > > > Also apparently there was an userspace application that made use of these > > keys, and required the usbhid driver to be unbound from them. > > > How come this is not the case any more? On our side, we are still using a custom userspace for the Jabra speakers (ie the jabra_vold daemon: https://chromium.googlesource.com/chromiumos/platform/jabra_vold/+/master plus some direct USB interfacing in a Chrome app). while If somebody is using the device another way, we can blacklist it or detach it on our side in the future, I'm somewhat surprised that it's working well through the HID interface with the Jabra speakerphone 510. Even if there is no longer any basic breakage, in my experience there are other challenges to overcome with the 510 firmware (at least the one I had on my devices) e.g. for the volume key to work more than once, you need to do a precise sequence on the USB audio interface every time one of the volume key is released. Do you have another kernel driver for this ? a userspace software ? >> >> >> Adding original quirk entry author (Vincent) to CC (and keeping the rest >> of message below for reference). >> >> > >> > See the original commit: >> > Commit 31b9779cb292 ("HID: ignore Jabra speakerphones HID interface") >> > >> > Testing the devices today reveals no such problems, and the >> > blacklisting can safely be removed. >> > >> > Signed-off-by: Niels Skou Olsen <nolsen@xxxxxxxxx> >> > --- >> > drivers/hid/hid-core.c | 2 -- >> > drivers/hid/hid-ids.h | 2 -- >> > 2 files changed, 4 deletions(-) >> > >> > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c >> > index 9bc9116..b49d7c4 100644 >> > --- a/drivers/hid/hid-core.c >> > +++ b/drivers/hid/hid-core.c >> > @@ -2697,8 +2697,6 @@ static const struct hid_device_id hid_ignore_list[] = { >> > { HID_USB_DEVICE(USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_1006) }, >> > { HID_USB_DEVICE(USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_1007) }, >> > { HID_USB_DEVICE(USB_VENDOR_ID_IMATION, USB_DEVICE_ID_DISC_STAKKA) }, >> > - { HID_USB_DEVICE(USB_VENDOR_ID_JABRA, USB_DEVICE_ID_JABRA_SPEAK_410) }, >> > - { HID_USB_DEVICE(USB_VENDOR_ID_JABRA, USB_DEVICE_ID_JABRA_SPEAK_510) }, >> > { HID_USB_DEVICE(USB_VENDOR_ID_JABRA, USB_DEVICE_ID_JABRA_GN9350E) }, >> > { HID_USB_DEVICE(USB_VENDOR_ID_KBGEAR, USB_DEVICE_ID_KBGEAR_JAMSTUDIO) }, >> > { HID_USB_DEVICE(USB_VENDOR_ID_KWORLD, USB_DEVICE_ID_KWORLD_RADIO_FM700) }, >> > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h >> > index b397a14..12b9179 100644 >> > --- a/drivers/hid/hid-ids.h >> > +++ b/drivers/hid/hid-ids.h >> > @@ -578,8 +578,6 @@ >> > #define USB_DEVICE_ID_ITE8595 0x8595 >> > >> > #define USB_VENDOR_ID_JABRA 0x0b0e >> > -#define USB_DEVICE_ID_JABRA_SPEAK_410 0x0412 >> > -#define USB_DEVICE_ID_JABRA_SPEAK_510 0x0420 >> > #define USB_DEVICE_ID_JABRA_GN9350E 0x9350 >> > >> > #define USB_VENDOR_ID_JESS 0x0c45 >> > -- >> > 2.7.4 >> > >> >> -- >> Jiri Kosina >> SUSE Labs >> > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
